Be explicit about impact of not writing caches#2079
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Sep 3, 2024
Merged
Be explicit about impact of not writing caches#2079openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
A follow-up to containers#2031 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
6fa975c to
cd7809d
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
kwilczynski
reviewed
Sep 4, 2024
| // if the layer is coming from a read-only store, do not attempt | ||
| // If the layer is coming from a read-only store, do not attempt | ||
| // to write to it. | ||
| // Therefore,we won’t find any matches in read-only-store layers, |
Member
There was a problem hiding this comment.
Missing space after the comma.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #2031 .