compression: Add some doc comments#1939
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Jun 3, 2024
Merged
compression: Add some doc comments#1939openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
Member
|
LGTM |
I'm digging in more to zstd:chunked and I hope these comments are useful. Signed-off-by: Colin Walters <walters@verbum.org>
af21344 to
d78daad
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
mtrmac
reviewed
Jun 7, 2024
| // <offset>:<length>:<uncompressed length> | ||
| TarSplitInfoKey = "io.github.containers.zstd-chunked.tarsplit-position" | ||
|
|
||
| // TarSplitChecksumKey is deprecated: Use the TOC.TarSplitDigest field instead, this annotation is no longer read nor written. |
Collaborator
There was a problem hiding this comment.
FWIW the exact // Deprecated: text is treated as special by Go tooling and linters.
(I know, that’s horrible.)
cgwalters
added a commit
to cgwalters/storage
that referenced
this pull request
Jun 7, 2024
- Address containers#1939 (review) - Also just go ahead and comment this out because it's not used, but I think it makes sense to retain as a historical reference Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm digging in more to zstd:chunked and I hope these comments are useful.