compression: Fix Deprecated: and actually comment out unused bits#1958
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Jun 7, 2024
Merged
Conversation
Contributor
cgwalters
commented
Jun 7, 2024
- Address compression: Add some doc comments #1939 (review)
- Also just go ahead and comment this out because it's not used, but I think it makes sense to retain as a historical reference
- Address containers#1939 (review) - Also just go ahead and comment this out because it's not used, but I think it makes sense to retain as a historical reference Signed-off-by: Colin Walters <walters@verbum.org>
mtrmac
reviewed
Jun 7, 2024
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Thanks for the follow-up!
Supposedly, all of c/storage has a stable API. That’s… not the case in practice.
Contributor
Author
This is under |
Collaborator
|
/lgtm
Oops, good point. |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
Why not delete this rather then comment it out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.