bring read mappings proc into c/storage#1882
Conversation
Signed-off-by: Kevin Hannon <kehannon@redhat.com>
giuseppe
left a comment
There was a problem hiding this comment.
second thoughts: should we just use GetHostIDMappings in Podman?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@giuseppe they are trying to stop using Podman code. |
|
We could make Podman use this interface possibly? |
|
LGTM |
I understand that, but if we already have an existing function doing the same thing (as it seems to be @kannon92 can you please try using |
|
I've opened a PR for Podman to drop the function and use the existing function from c/storage: containers/podman#22328 We can do the same in CRI-O and not require |
|
I see. I did use that in cri-o/cri-o#7990. We can drop this PR if you think the above one is the right way to go. |
yes let's just revert this change. I've opened a PR: #1884 |
As I was working on cri-o/cri-o#7990, I found that ReadMappingsProc was the only function that was missing from pkg/unshare.
@giuseppe mention that this would be a good candidate for c/storage.
This PR adds this function to pkg/unshare. Once this is released, we could drop this from podman.