Turn DType testing back on#144
Merged
rhatdan merged 1 commit intocontainers:masterfrom Jan 4, 2018
TomSweeneyRedHat:dev/tsweeney/dtype
Merged
Turn DType testing back on#144rhatdan merged 1 commit intocontainers:masterfrom TomSweeneyRedHat:dev/tsweeney/dtype
rhatdan merged 1 commit intocontainers:masterfrom
TomSweeneyRedHat:dev/tsweeney/dtype
Conversation
rhatdan
reviewed
Jan 4, 2018
drivers/overlay/overlay.go
Outdated
| logrus.Warn(overlayutils.ErrDTypeNotSupported("overlay", backingFs)) | ||
| // TODO: Will make fatal when CRI-O Has AMI built on RHEL7.4 | ||
| // return nil, overlayutils.ErrDTypeNotSupported("overlay", backingFs) | ||
| return nil, overlayutils.ErrDTypeNotSupported("overlay", backingFs) |
Member
There was a problem hiding this comment.
Looks like this should be false not nil
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
Member
|
LGTM. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com
Reverting #106 to error on DType rather than just warn as support should have been added to the CI for this.