Move no Dtype on Overlay from Error to warning.#106
Merged
rhatdan merged 2 commits intocontainers:masterfrom Sep 29, 2017
Merged
Move no Dtype on Overlay from Error to warning.#106rhatdan merged 2 commits intocontainers:masterfrom
rhatdan merged 2 commits intocontainers:masterfrom
Conversation
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Member
|
LGTM. In general, do we mark a change like this with a TODO in the comments? Also should a Trello card be created to go turn this back on so we don't forget to later? |
Currently RHEL7.4 or later OS is required to support DType well. We want to eventually make this an error if you select overlay on a file system without DType, but for now in order to allow containers/storage to get merged into CRI-O we need to relax this constraint since the Test infrastucture does not have support. Once we have the support we can revert this change. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Member
Author
|
Yes a trello card would be good, also need a card to add tests to make sure overlayfs with quota is actually working. |
Member
|
LGTM. |
Member
|
kk, I'll spin the Trello cards up then. |
Contributor
|
Let us get this in for now while we get the amis sorted out. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move lack of DTYpe on Overlay from Error down to Warning, temporarily until infrastructure CI has updated VMs with correct support.
Moby currently has the same compromise.