fix logic when not creating a workdir#9231
Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom Feb 5, 2021
Merged
fix logic when not creating a workdir#9231openshift-merge-robot merged 1 commit intocontainers:masterfrom
openshift-merge-robot merged 1 commit intocontainers:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
reviewed
Feb 4, 2021
Member
Luap99
left a comment
There was a problem hiding this comment.
LGTM
I can confirm that this fixes my issue.
edsantiago
reviewed
Feb 4, 2021
Member
|
LGTM once Ed's test issues are addressed |
16b8b55 to
53421b4
Compare
Member
|
LGTM |
edsantiago
reviewed
Feb 5, 2021
test/system/030-run.bats
Outdated
Member
There was a problem hiding this comment.
There's a mix of spaces and tabs on this line.
Member
Author
There was a problem hiding this comment.
Need to fix my vimrc. Thank you!
When resolving the workdir of a container, we may need to create unless the user set it explicitly on the command line. Otherwise, we just do a presence check. Unfortunately, there was a missing return that lead us to fall through into attempting to create and chown the workdir. That caused a regression when running on a read-only root fs. Fixes: containers#9230 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
53421b4 to
821ef64
Compare
Member
|
/lgtm |
Member
|
/hold cancel |
This was referenced Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resolving the workdir of a container, we may need to create it unless
the user sets it explicitly on the command line. Otherwise, we just do a
presence check. Unfortunately, there was a missing return that lead us
to fall through into attempting to create and chown the workdir. That
caused a regression when running on a read-only root fs.
Fixes: #9230
Signed-off-by: Valentin Rothberg rothberg@redhat.com
@Luap99 PTAL
It took me longer than I want to admit until I found an easy way to test it (doing the unshare+mount dance didn't work out well in the system tests).