Skip to content

Update VM images#24759

Merged
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
Luap99:new-images
Dec 13, 2024
Merged

Update VM images#24759
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
Luap99:new-images

Conversation

@Luap99
Copy link
Copy Markdown
Member

@Luap99 Luap99 commented Dec 4, 2024

from containers/automation_images#396

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2024
@packit-as-a-service
Copy link
Copy Markdown

packit-as-a-service bot commented Dec 4, 2024

Ephemeral COPR build failed. @containers/packit-build please check.

1 similar comment
@packit-as-a-service
Copy link
Copy Markdown

packit-as-a-service bot commented Dec 4, 2024

Ephemeral COPR build failed. @containers/packit-build please check.

@Luap99
Copy link
Copy Markdown
Member Author

Luap99 commented Dec 5, 2024

Checkpoint/restore is completely broken on rawhide: https://bugzilla.redhat.com/show_bug.cgi?id=2328985
So I guess we have to skip all checkpoint tests here for this to pass CI.

@lsm5
Copy link
Copy Markdown
Member

lsm5 commented Dec 5, 2024

Checkpoint/restore is completely broken on rawhide: https://bugzilla.redhat.com/show_bug.cgi?id=2328985 So I guess we have to skip all checkpoint tests here for this to pass CI.

can we either skip all checkpoint tests on rawhide or maybe defer rawhide image update?

lsm5
lsm5 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming happy tests.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99 Luap99 mentioned this pull request Dec 9, 2024
Closed
@Luap99
Update VM images
ae9120a 
from containers/automation_images#396

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99
test/e2e: remove outdated SkipOnOSVersion() calls
e74df8c 
Both of them are for fedora 36 which is long EOL and thus not run in our
CI.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99
test/e2e: SkipOnOSVersion() add reason field
e6d8603 
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99
Copy link
Copy Markdown
Member Author

Luap99 commented Dec 13, 2024

Ok finally all rawhide regressions are fixed and tests are green.

@giuseppe @lsm5 PTAL and merge

@baude
Copy link
Copy Markdown
Member

baude commented Dec 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8030093 into containers:main Dec 13, 2024
@Luap99 Luap99 deleted the new-images branch December 13, 2024 14:23
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Mar 14, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lsm5 lsm5 lsm5 approved these changes

Assignees

@baude baude

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Luap99 @lsm5 @baude