make remotesystem: fail early if serial tests fail#24698
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Nov 28, 2024
Merged
make remotesystem: fail early if serial tests fail#24698openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
Contributor
|
@Luap99 FYI, to possibly save you time. |
mtrmac
reviewed
Nov 27, 2024
Contributor
mtrmac
left a comment
There was a problem hiding this comment.
LGTM, #24697 confirms that this commit does cause the test failures to be detected.
Thank you so much @edsantiago !
Exit status was being lost due to sequential bats invocations. Solution: preserve exit status of first (serial) run, and skip parallel tests if those fail. I am so, so sorry. Signed-off-by: Eduardo Santiago <ed@edsantiago.com>
Luap99
approved these changes
Nov 28, 2024
Member
Luap99
left a comment
There was a problem hiding this comment.
/lgtm
Thanks @edsantiago. Didn't expect you to still read PRs :)
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely my fault, and I'm so sorry.
Untested because I use podman on my home system (for real stuff) and can't afford a
make remotesystemnuke.