DO NOT MERGE: remote test setup failures are ignored#24697
Closed
mtrmac wants to merge 2 commits intocontainers:mainfrom
Closed
DO NOT MERGE: remote test setup failures are ignored#24697mtrmac wants to merge 2 commits intocontainers:mainfrom
mtrmac wants to merge 2 commits intocontainers:mainfrom
Conversation
We have seen the test failure ignored; testing. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3ee7a87 to
f2dfbba
Compare
edsantiago
reviewed
Nov 27, 2024
Makefile
Outdated
Comment on lines
+709
to
+710
| PODMAN=$(CURDIR)/bin/podman QUADLET=$(CURDIR)/bin/quadlet bats -T --filter-tags '!ci:parallel' test/system/ ; out=$?; echo "===LOCALSYSTEM SERIAL EXIT STATUS = $$out"; exit $$out | ||
| PODMAN=$(CURDIR)/bin/podman QUADLET=$(CURDIR)/bin/quadlet bats -T --filter-tags ci:parallel -j $$(nproc) test/system/ ; out=$?; echo "===LOCALSYSTEM PARALLEL EXIT STATUS = $$out"; exit $$out |
Contributor
Author
There was a problem hiding this comment.
Oh, I was not even looking at the right Make rule. Thank you!
Signed-off-by: Eduardo Santiago <ed@edsantiago.com>
f2dfbba to
5bffa4d
Compare
Contributor
Author
|
Rebased to include #24698, so this should now report a failure. |
Contributor
Author
|
All remote tests failures are now correctly detected here, confirming the fix in #24698 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #24686 (comment) :
This is an attempt to reproduce, and add more debug logging.
Does this PR introduce a user-facing change?