Prepare tests for better reuse with zstd:chunked pulls#23379
Merged
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom Jul 24, 2024
Merged
Prepare tests for better reuse with zstd:chunked pulls#23379openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
openshift-merge-bot[bot] merged 3 commits intocontainers:mainfrom
Conversation
"/my-alpine" is also being used by tests in search_test.go; use unique names to make sure we are trying to pull the encrypted images created in the test. Purely to avoid doubt, this should not actually change (test) behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Actually test decryption, instead of handling of TLS failures. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…ault It is not the default _yet_, but we are testing such setups. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
Author
|
Compare #23348 testing the future c/changes. |
Member
|
LGTM |
Member
|
@mheon @Luap99 @baude @ashley-cui @l0rd PTAL |
Member
|
@edsantiago PTAL |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?