podman-remote import|export#2227
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
☔ The latest upstream changes (presumably #2205) made this pull request unmergeable. Please resolve the merge conflicts. |
3550a94 to
d7f18fc
Compare
|
/retest |
|
bot, retest this please |
cmd/podman/export.go
Outdated
There was a problem hiding this comment.
Couldn't the client code "proxy" /dev/stdout to a temporary file? I understand the API not doing this extra work but the client could "hide" the difference. Yes, local vs remote will be faster without the hop but that is going to be true anyway.
libpod/adapter/client.go
Outdated
There was a problem hiding this comment.
I would add a note in the comments detailing the connection state if r.Connect() fails? Is the old connection still open? still upgraded? still ...
libpod/adapter/runtime.go
Outdated
There was a problem hiding this comment.
Are we forking here? Otherwise, it looks like we're done always between #134-139
|
LGTM |
|
/lgtm |
addition of import and export for the podman-remote client. This includes the ability to send and receive files between the remote-client and the "podman" host using an upgraded varlink connection. Signed-off-by: baude <bbaude@redhat.com>
|
/lgtm |
addition of import and export for the podman-remote client. This includes
the ability to send and receive files between the remote-client and the
"podman" host using an upgraded varlink connection.
Signed-off-by: baude bbaude@redhat.com