Skip to content

Handle artifacts not found more gracefully#134

Closed
umohnani8 wants to merge 1 commit intocontainers:masterfrom
umohnani8:kpod_inspect
Closed

Handle artifacts not found more gracefully#134
umohnani8 wants to merge 1 commit intocontainers:masterfrom
umohnani8:kpod_inspect

Conversation

@umohnani8
Copy link
Member

If the artifacts file "create-config" is not found
when doing kpod inspect, just print the error and
move on to print out the rest of the inspect info

Addresses #131 (comment)

Signed-off-by: umohnani8 umohnani@redhat.com

@umohnani8
Copy link
Member Author

@rhatdan @mheon PTAL

@rhatdan
Copy link
Member

rhatdan commented Dec 13, 2017

LGTM

1 similar comment
@mheon
Copy link
Member

mheon commented Dec 13, 2017

LGTM

If the artifacts file "create-config" is not found
when doing kpod inspect, just print the error and
move on to print out the rest of the inspect info

Signed-off-by: umohnani8 <umohnani@redhat.com>
@mheon
Copy link
Member

mheon commented Dec 13, 2017

Merging
@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 7c5a38c has been approved by mheon

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 7c5a38c with merge 29fc406...

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baude
Copy link
Member

baude commented Dec 14, 2017

@rh-atomic-bot retry

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 7c5a38c with merge 900afc9...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: mheon
Pushing 900afc9 to master...

@umohnani8 umohnani8 deleted the kpod_inspect branch March 16, 2018 14:41
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants