[v4.1.1-rhel] Fix AttributeError: cython_sources#19359
Merged
openshift-merge-robot merged 1 commit intocontainers:v4.1.1-rhelfrom Jul 28, 2023
Merged
Conversation
Apparent Cython regression causing a warning and traceback when installing PyYAML with pip: Ref. Upstream issue 601: https://github.com/yaml/pyyaml/issues/ Ref. warning message: ``` ******************************************************************************** The license_file parameter is deprecated, use license_files instead. By 2023-Oct-30, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. ******************************************************************************** ``` Ref. traceback snippet: ``` Traceback (most recent call last): File "/var/tmp/go/src/github.com/containers/podman/venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module> main() ...cut... File "<string>", line 201, in get_source_files File "/tmp/pip-build-env-yiijk0jv/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 107, in __getattr__ raise AttributeError(attr) AttributeError: cython_sources ``` Signed-off-by: Chris Evich <cevich@redhat.com>
Member
Author
|
@jwhonce would you mind taking a look at this? I think it's okay, the tests think it's okay, but this "fix" is based on some less-than ideal assumptions/inferences. |
This was referenced Jul 25, 2023
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparent Cython regression causing a warning and traceback when installing PyYAML with pip:
Ref. Upstream issue 601: https://github.com/yaml/pyyaml/issues/
Ref. warning message:
Ref. traceback snippet:
Does this PR introduce a user-facing change?