Skip to content

[v4.1.1-rhel] Fix AttributeError: cython_sources#19359

Merged
openshift-merge-robot merged 1 commit intocontainers:v4.1.1-rhelfrom
cevich:v4.1.1-rhel_fix_python_license_file
Jul 28, 2023
Merged

[v4.1.1-rhel] Fix AttributeError: cython_sources#19359
openshift-merge-robot merged 1 commit intocontainers:v4.1.1-rhelfrom
cevich:v4.1.1-rhel_fix_python_license_file

Conversation

@cevich
Copy link
Copy Markdown
Member

@cevich cevich commented Jul 25, 2023

Apparent Cython regression causing a warning and traceback when installing PyYAML with pip:

Ref. Upstream issue 601: https://github.com/yaml/pyyaml/issues/

Ref. warning message:

********************************************************************************
The license_file parameter is deprecated, use license_files instead.
By 2023-Oct-30, you need to update your project and remove deprecated calls
or your builds will no longer be supported.
See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
********************************************************************************

Ref. traceback snippet:

Traceback (most recent call last):
  File "/var/tmp/go/src/github.com/containers/podman/venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
    main()
...cut...
  File "<string>", line 201, in get_source_files
  File "/tmp/pip-build-env-yiijk0jv/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 107, in __getattr__
    raise AttributeError(attr)
AttributeError: cython_sources

Does this PR introduce a user-facing change?

None

Apparent Cython regression causing a warning and traceback when
installing PyYAML with pip:

Ref. Upstream issue 601: https://github.com/yaml/pyyaml/issues/

Ref. warning message:
```
********************************************************************************
The license_file parameter is deprecated, use license_files instead.
By 2023-Oct-30, you need to update your project and remove deprecated calls
or your builds will no longer be supported.
See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
********************************************************************************
```

Ref. traceback snippet:
```
Traceback (most recent call last):
  File "/var/tmp/go/src/github.com/containers/podman/venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
    main()
...cut...
  File "<string>", line 201, in get_source_files
  File "/tmp/pip-build-env-yiijk0jv/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 107, in __getattr__
    raise AttributeError(attr)
AttributeError: cython_sources
```

Signed-off-by: Chris Evich <cevich@redhat.com>
@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 25, 2023
@cevich cevich marked this pull request as ready for review July 25, 2023 18:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2023
@cevich cevich requested a review from jwhonce July 25, 2023 18:03
@cevich
Copy link
Copy Markdown
Member Author

cevich commented Jul 25, 2023

@jwhonce would you mind taking a look at this? I think it's okay, the tests think it's okay, but this "fix" is based on some less-than ideal assumptions/inferences.

Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@umohnani8 PTAL

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jul 28, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3bb1a31 into containers:v4.1.1-rhel Jul 28, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants