Skip to content

libpod: switch to golang native error wrapping#14828

Merged
openshift-ci[bot] merged 1 commit intocontainers:mainfrom
saschagrunert:errors-libpod
Jul 5, 2022
Merged

libpod: switch to golang native error wrapping#14828
openshift-ci[bot] merged 1 commit intocontainers:mainfrom
saschagrunert:errors-libpod

Conversation

@saschagrunert
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert commented Jul 5, 2022 •
edited
Loading

We now use the golang error wrapping format specifier %w instead of the deprecated github.com/pkg/errors package.

Does this PR introduce a user-facing change?

NONE

It's a huge one, but the libpod/pkg errors.Cause chain is somehow interconnected.

@saschagrunert saschagrunert changed the title libpod: switch to golang native error wrapping WIP: libpod: switch to golang native error wrapping Jul 5, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 5, 2022
@saschagrunert saschagrunert force-pushed the errors-libpod branch 7 times, most recently from 2fd334e to 3a148ae Compare July 5, 2022 10:01
@saschagrunert saschagrunert mentioned this pull request Jul 5, 2022
Closed
6 tasks
@saschagrunert saschagrunert force-pushed the errors-libpod branch 2 times, most recently from 0ef3e5f to 30220a7 Compare July 5, 2022 11:22
@saschagrunert saschagrunert changed the title WIP: libpod: switch to golang native error wrapping libpod: switch to golang native error wrapping Jul 5, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2022
vrothberg
vrothberg reviewed Jul 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mheon PTAL

@saschagrunert
Copy link
Copy Markdown
Member Author

saschagrunert commented Jul 5, 2022

CI is green but I need another rebase 🙃

@saschagrunert
libpod: switch to golang native error wrapping
251d916 
We now use the golang error wrapping format specifier `%w` instead of
the deprecated github.com/pkg/errors package.

[NO NEW TESTS NEEDED]

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jul 5, 2022

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2022
@saschagrunert
Copy link
Copy Markdown
Member Author

saschagrunert commented Jul 5, 2022

CI seems to be green in a bit, can we lift the hold @containers/podman-maintainers?

@vrothberg
Copy link
Copy Markdown
Member

vrothberg commented Jul 5, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2022
@mheon
Copy link
Copy Markdown
Member

mheon commented Jul 5, 2022

LGTM for posterity. Let's get this landed.

@openshift-ci openshift-ci bot merged commit 39fc5d1 into containers:main Jul 5, 2022
@saschagrunert saschagrunert deleted the errors-libpod branch July 5, 2022 16:11
@shanesmith shanesmith mentioned this pull request Jul 6, 2022
Merged
shanesmith added a commit to shanesmith/podman that referenced this pull request Jul 6, 2022
@shanesmith
Fix qemu machine startHostNetworking always failing
a589812 
Issue introduced in containers#14828

[NO NEW TESTS NEEDED]

Signed-off-by: Shane Smith <shane.smith@shopify.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vrothberg vrothberg vrothberg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rhatdan rhatdan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saschagrunert @rhatdan @vrothberg @mheon