Cirrus: enable Fedora 36 aarch64 tasks on EC2 by lsm5 · Pull Request #14801 · containers/podman

lsm5 · 2022-07-01T14:24:59Z

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

Does this PR introduce a user-facing change?

None

Piggybacks on #14569

.cirrus.yml

cevich

Looking good so far

.cirrus.yml

lsm5 · 2022-07-26T18:49:57Z

Next time you rebase, please remove the 761e9f2 commit; and I think you can remove 8d9b7ca and 6b5c467 as well

@edsantiago do we not need them anymore or do you need the removal to investigate something else?

edsantiago · 2022-07-26T18:51:42Z

All those have merged, although in slightly different form than when you rebased on them. The code that merged is Truth, and should not be clobbered by older versions.

lsm5 · 2022-07-26T18:56:14Z

repushed and skip_if_aarch64 commented out to check for failure consistency.

lsm5 · 2022-07-26T21:33:55Z

I notice you didn't skip any of the SELinux tests. Did that get resolved with the new images?

the last failure only showed the system test failures and nothing else (i guess others were cancelled). I'll see how this run goes.

the system test failures look consistent. It's the same 2 tests failing for remote and non-remote.

.cirrus.yml

contrib/cirrus/cirrus_yaml_test.py

contrib/cirrus/runner.sh

cevich

Overall this is a fantastic effort that should be commended. I made a few comments that should be addressed, but overall they're all pretty minor. LGTM with some minor fixups and assuming tests pass.

cevich

/lgtm
/hold

edsantiago · 2022-07-27T18:56:37Z

        _ruamel_yaml.c:6:10: fatal error: Python.h: No such file or directory
            6 | #include "Python.h"
              |          ^~~~~~~~~~

cevich · 2022-07-27T19:00:16Z

Oof, WTF. Doing some digging...

edsantiago · 2022-07-27T19:01:52Z

nonono, that's just because @lsm5 tried removing something, but I guess it can't be removed. Should be easy to just add it back.

.cirrus.yml

cevich · 2022-07-27T19:07:26Z

nonono, that's just because @lsm5 tried removing something, but I guess it can't be removed. Should be easy to just add it back.

Our VM images should be uniform across architectures. Since we're not seeing this error on the x86 tasks, something is clearly not uniform.

Looking in c/automation_images, cache_images/fedora_packaging.sh we don't mention python-devel anywhere. I'm taking a quick poke around to see if I can find where it gets brought.

cevich · 2022-07-27T19:14:58Z

Okay, it looks like the python-devel is missing from the regular images too. If you want to add back in the dnf install for those two tasks (Validate and consistency?) I think there's no need to check the architecture, just always install it. Maybe drop a TODO comment suggesting we bundle it into the images for stability. But I don't see that work as critical ATM.

cevich · 2022-07-27T19:19:21Z

Opened containers/automation_images#159

new file: test/e2e/config_arm64.go Tests that fail on aarch64 have been skipped with `skip_if_aarch64`. Co-authored-by: Chris Evich <cevich@redhat.com> Co-authored-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

lsm5 · 2022-07-27T19:28:58Z

@edsantiago @cevich removed that smallcontainer line and added python3-devel back. PTAL once again please, sorry about the PITA :(

cevich

/lgtm
/hold

openshift-ci · 2022-07-27T20:11:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lsm5]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cevich · 2022-07-27T20:11:44Z

sorry about the PITA :(

It's no problem bud.

edsantiago · 2022-07-27T21:23:05Z

remote is a flake which should go away as soon as #15090 merges.

edsantiago · 2022-07-27T22:07:24Z

LGTM but that resource flake is going to cause a lot of pain. I foresee an immediate followup PR to skip it.

Thanks for your perseverance @lsm5.

vrothberg

/lgtm

Thanks everybody for working on this. I am very excited!

vrothberg · 2022-07-28T09:30:05Z

/hold cancel

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 1, 2022

lsm5 force-pushed the ec2-aarch64 branch 5 times, most recently from 57346a1 to 8785850 Compare July 1, 2022 14:58

lsm5 commented Jul 1, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

lsm5 force-pushed the ec2-aarch64 branch 8 times, most recently from 37bb6e9 to 48d1ba2 Compare July 1, 2022 19:36

cevich reviewed Jul 1, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

cevich reviewed Jul 1, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

cevich reviewed Jul 1, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

cevich reviewed Jul 1, 2022

View reviewed changes

lsm5 force-pushed the ec2-aarch64 branch 2 times, most recently from 14cd682 to c7a7aad Compare July 1, 2022 20:08

cevich reviewed Jul 1, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

cevich reviewed Jul 1, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

lsm5 force-pushed the ec2-aarch64 branch 5 times, most recently from 9a01a58 to 2ab62ba Compare July 4, 2022 18:39

cevich reviewed Jul 27, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

cevich reviewed Jul 27, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

cevich reviewed Jul 27, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

cevich reviewed Jul 27, 2022

View reviewed changes

contrib/cirrus/cirrus_yaml_test.py Outdated Show resolved Hide resolved

cevich reviewed Jul 27, 2022

View reviewed changes

contrib/cirrus/runner.sh Outdated Show resolved Hide resolved

cevich approved these changes Jul 27, 2022

View reviewed changes

cevich mentioned this pull request Jul 27, 2022

Cirrus: Use pre-installed bats #14719

Merged

cevich approved these changes Jul 27, 2022

View reviewed changes

cevich reviewed Jul 27, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

cevich approved these changes Jul 27, 2022

View reviewed changes

vrothberg reviewed Jul 28, 2022

View reviewed changes

This was referenced Aug 10, 2022

sdnotify doesn't work on aarch64 #15277

Closed

SELinux broken on aarch64 #15280

Closed

Conversation

lsm5 commented Jul 1, 2022

Does this PR introduce a user-facing change?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cevich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lsm5 commented Jul 26, 2022

Uh oh!

edsantiago commented Jul 26, 2022

Uh oh!

lsm5 commented Jul 26, 2022

Uh oh!

lsm5 commented Jul 26, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cevich left a comment

Choose a reason for hiding this comment

Uh oh!

cevich left a comment

Choose a reason for hiding this comment

Uh oh!

edsantiago commented Jul 27, 2022

Uh oh!

cevich commented Jul 27, 2022

Uh oh!

edsantiago commented Jul 27, 2022

Uh oh!

Uh oh!

cevich commented Jul 27, 2022

Uh oh!

cevich commented Jul 27, 2022

Uh oh!

cevich commented Jul 27, 2022

Uh oh!

lsm5 commented Jul 27, 2022

Uh oh!

cevich left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 27, 2022

Uh oh!

cevich commented Jul 27, 2022

Uh oh!

edsantiago commented Jul 27, 2022

Uh oh!

edsantiago commented Jul 27, 2022

Uh oh!

vrothberg left a comment

Choose a reason for hiding this comment

Uh oh!

vrothberg commented Jul 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants