podman pod create --uts support#14501
Merged
openshift-ci[bot] merged 1 commit intocontainers:mainfrom Jul 6, 2022
Merged
Conversation
Member
|
The whitespace demons are not happy with you @cdoern. |
Contributor
Author
they are the bane of my existence @TomSweeneyRedHat |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Contributor
Author
|
@containers/podman-maintainers PTAL |
Luap99
reviewed
Jun 7, 2022
8e3c0c1 to
d08b8f9
Compare
Contributor
Author
|
same goes for this one. do not merge until I add support in pod clone |
rhatdan
reviewed
Jun 28, 2022
vrothberg
reviewed
Jul 5, 2022
add support for the --uts flag in pod create, allowing users to avoid issues with default values in containers.conf. uts follows the same format as other namespace flags: --uts=private (default), --uts=host, --uts=ns:PATH resolves containers#13714 Signed-off-by: Charlie Doern <cdoern@redhat.com>
vrothberg
reviewed
Jul 5, 2022
Member
vrothberg
left a comment
There was a problem hiding this comment.
LGTM
@containers/podman-maintainers PTAL
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold cancel |
cdoern
added a commit
to cdoern/podman
that referenced
this pull request
Jul 7, 2022
somehow, containers#14501 got through CI even though the remote tests fail. The testa are failing due to the PodSpecGenerator not containing the UTSNs entitiy and infra's spec is not yet allowed to be accessed remotely [NO NEW TESTS NEEDED] resolves containers#14847 Signed-off-by: Charlie Doern <cdoern@redhat.com>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Jul 7, 2022
copy/paste error in containers#14501. Signed-off-by: Ed Santiago <santiago@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for the --uts flag in pod create, allowing users to avoid
issues with default values in containers.conf.
uts follows the same format as other namespace flags:
--uts=private (default), --uts=host, --uts=ns:PATH
resolves #13714
Signed-off-by: cdoern cdoern@redhat.com
Does this PR introduce a user-facing change?