Add TransportFromImageName procedure#631
Merged
mtrmac merged 1 commit intocontainers:masterfrom May 18, 2019
Merged
Conversation
TristanCacqueray
added a commit
to TristanCacqueray/skopeo
that referenced
this pull request
May 17, 2019
This change fixes skopeo usage in restricted environment such as bubblewrap where it doesn't need extra capabilities or user namespace to perform its action. Close containers#649 Depends-On: containers/image#631 Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
53b44b0 to
dee4fe1
Compare
mtrmac
reviewed
May 18, 2019
This change adds a new alltransports.TransportFromImageName procedure to get the transport's name of an image without parsing the store reference. Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
mtrmac
reviewed
May 18, 2019
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Thanks! LGTM pending tests.
TristanCacqueray
added a commit
to TristanCacqueray/skopeo
that referenced
this pull request
May 18, 2019
Depends-On: containers/image#631 Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
TristanCacqueray
added a commit
to TristanCacqueray/skopeo
that referenced
this pull request
May 18, 2019
Depends-On: containers/image#631 Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
TristanCacqueray
added a commit
to TristanCacqueray/skopeo
that referenced
this pull request
May 18, 2019
Depends-On: containers/image#631 Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new transports.TransportFromImageName procedure
to get the transport's name of an image without parsing the store
reference.