Update stubs to match signature of actual methods#2541
Merged
mtrmac merged 1 commit intocontainers:mainfrom Nov 12, 2024
Merged
Update stubs to match signature of actual methods#2541mtrmac merged 1 commit intocontainers:mainfrom
mtrmac merged 1 commit intocontainers:mainfrom
Conversation
Collaborator
|
Thanks! First, https://github.com/containers/image/blob/main/CONTRIBUTING.md#sign-your-prs please, we can’t really even look at contributions with unclear copyright status. |
60a2ff3 to
e6ba63d
Compare
Signed-off-by: Roselyn Coales <github@spangle.org.uk>
Contributor
Author
|
So sorry I missed this and then got pulled away to other things and forgot to update it! |
mtrmac
approved these changes
Nov 12, 2024
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
I’m afraid we broke that build another way since…
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2526 has broken building v5.32.2 with the
containers_image_fulcio_stubandcontainers_image_rekor_stubbuild tags, as the signatures forverifyRekorFulcio()andVerifyRekorSET()were updated without updating the corresponding stubs.This PR updates the stubs to match