Skip to content

Move JSONFormatToInvalidSignatureError to an unconditionally-included file#2632

Merged
rhatdan merged 1 commit intocontainers:mainfrom
mtrmac:stubs-broken
Jan 7, 2025
Merged

Move JSONFormatToInvalidSignatureError to an unconditionally-included file#2632
rhatdan merged 1 commit intocontainers:mainfrom
mtrmac:stubs-broken

Conversation

@mtrmac
Copy link
Copy Markdown
Collaborator

@mtrmac mtrmac commented Nov 12, 2024

otherwise:

% go build -tags ' containers_image_fulcio_stub containers_image_rekor_stub' ./...
# github.com/containers/image/v5/signature/internal
signature/internal/sigstore_payload.go:83:9: undefined: JSONFormatToInvalidSignatureError

@mtrmac mtrmac force-pushed the stubs-broken branch 3 times, most recently from 503fcda to e5e9c24 Compare November 21, 2024 20:07
@mtrmac mtrmac force-pushed the stubs-broken branch 5 times, most recently from 204ca8b to 63679c9 Compare November 29, 2024 00:15
@mtrmac mtrmac force-pushed the stubs-broken branch 2 times, most recently from 72c3e56 to 78b8ca7 Compare December 14, 2024 00:13
… file

otherwise:
> % go build -tags ' containers_image_fulcio_stub containers_image_rekor_stub' ./...
> # github.com/containers/image/v5/signature/internal
> signature/internal/sigstore_payload.go:83:9: undefined: JSONFormatToInvalidSignatureError

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jan 7, 2025

/approve
/lgtm

@rhatdan rhatdan merged commit 43c2a74 into containers:main Jan 7, 2025
@mtrmac mtrmac deleted the stubs-broken branch January 7, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants