Don't store signatures if there is none of them#2001
Merged
mtrmac merged 1 commit intocontainers:mainfrom Jun 15, 2023
Merged
Conversation
c016ed9 to
90699ce
Compare
mtrmac
reviewed
Jun 15, 2023
Collaborator
mtrmac
left a comment
There was a problem hiding this comment.
Thanks.
If we are improving this, the major user-visible aspect is actually that (typically during a pull) it may be the Commit that takes a long time, and that’s currently being attributed to storing signatures. That’s certainly not ideal; but just dropping that and attributing the delay to the previous layer copies would not be clearly better.
So I think the Commit step should cause a progress log (potentially with a per-transport opt-in to avoid noise?), and we can revisit the signature step afterwards.
Currently, the copy command prints the message 'Storing signatures' and calls the signature storing function, even if there are no signatures present. This can mislead users and make them believe that there are image signatures. The proposed change modifies the copy function to print the message and invoke the image storing function only if there is at least one signature. Signed-off-by: Mike <mike.sul@foundries.io>
90699ce to
8bbc9c4
Compare
Contributor
Author
The previous step is not layer copy iiuc, rather Do you mean that |
Collaborator
|
My mistake; it’s the manifest step indeed. That’s certainly less misleading than a layer copy — a bit: “why does writing a 1KB file take a minute?”. |
Collaborator
|
Either way, this is an improvement. |
1 task
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Jun 27, 2023
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
ashley-cui
pushed a commit
to ashley-cui/podman
that referenced
this pull request
Jul 1, 2023
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
lsm5
pushed a commit
to lsm5/podman
that referenced
this pull request
Jan 9, 2026
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
lsm5
pushed a commit
to lsm5/podman
that referenced
this pull request
Jan 12, 2026
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
lsm5
pushed a commit
to lsm5/podman
that referenced
this pull request
Jan 12, 2026
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
lsm5
pushed a commit
to lsm5/podman
that referenced
this pull request
Jan 14, 2026
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
lsm5
pushed a commit
to lsm5/podman
that referenced
this pull request
Jan 19, 2026
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
lsm5
pushed a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Jan 19, 2026
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
lsm5
pushed a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Jan 19, 2026
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
cevich
pushed a commit
to cevich/podman
that referenced
this pull request
Jan 21, 2026
(cherry picked from commit 2c0cd36) After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
cevich
pushed a commit
to cevich/podman
that referenced
this pull request
Jan 22, 2026
(cherry picked from commit 2c0cd36) After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
cevich
pushed a commit
to cevich/podman
that referenced
this pull request
Jan 28, 2026
(cherry picked from commit 2c0cd36) After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
lsm5
pushed a commit
to lsm5/podman
that referenced
this pull request
Jan 29, 2026
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 Signed-off-by: Paul Holzinger <pholzing@redhat.com> (cherry picked from commit 6eaf8a2) Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
lsm5
added a commit
to lsm5/podman
that referenced
this pull request
Jan 29, 2026
After[1] c/image no longer prints "Storing signatures" so we should not check for it. [1] containers/image#2001 (partial cherry-pick from commit 6eaf8a2) Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the copy command prints the message 'Storing signatures' and calls the signature storing function, even if there are no signatures present. This can mislead users and make them believe that there are image signatures.
The proposed change modifies the copy function to print the message and invoke the image storing function only if there is at least one signature.