gvproxy: command: Add AddServiceEndpoint#468
Merged
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom Feb 27, 2025
Merged
gvproxy: command: Add AddServiceEndpoint#468openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
Conversation
This adds GvproxyCommand.AddServiceEndpoint() for the newly added --services argument. This API is a helper for users of gvproxy to have a more convenient way to generate its command line. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This cleans up indirect deps a little bit. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
LGTM |
Collaborator
|
/lgtm |
cfergeau
added a commit
to cfergeau/macadam
that referenced
this pull request
Feb 27, 2025
Now that containers/gvisor-tap-vsock#468 is merged, we no longer need to use a go.mod replacement for gvisor-tap-vsock.
cfergeau
added a commit
to cfergeau/macadam
that referenced
this pull request
Feb 28, 2025
Now that containers/gvisor-tap-vsock#468 is merged, we no longer need to use a go.mod replacement for gvisor-tap-vsock.
cfergeau
added a commit
to crc-org/macadam
that referenced
this pull request
Mar 4, 2025
Now that containers/gvisor-tap-vsock#468 is merged, we no longer need to use a go.mod replacement for gvisor-tap-vsock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds GvproxyCommand.AddServiceEndpoint() for the newly added
--services argument. This API is a helper for users of gvproxy to have a
more convenient way to generate its command line.