seccomp: custom annotation to load raw bpf#578
Merged
rhatdan merged 1 commit intocontainers:masterfrom Feb 11, 2021
Merged
Conversation
cb9cbfd to
6551493
Compare
698e586 to
9d29983
Compare
Member
Author
|
some initial plumbing for Podman: https://github.com/giuseppe/libpod/tree/easyseccomp |
Member
|
Why have both a data field and a file field? |
Member
Author
the data file makes it easier to use with the existing container tools. Instead the file field is easier for development as I can change the BPF program and test the container just by setting an annotation. I can drop the file field though as I can live with the data field |
Member
|
I just found having two ways to do this, confusing. |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Feb 11, 2021
start plumbing support for easyseccomp. Requires: containers/crun#578 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
9d29983 to
a140be8
Compare
Member
Author
|
dropped the |
Add an annotation `run.oci.seccomp_bpf_data` to ignore the seccomp section in the OCI configuration file and use the specified file as the raw data to the `seccomp(SECCOMP_SET_MODE_FILTER)` syscall. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
a140be8 to
df01709
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an annotation
run.oci.seccomp_bpf_fileto ignore the seccompsection in the OCI configuration file and use the specified file as
the raw data to the
seccomp(SECCOMP_SET_MODE_FILTER)syscall.this is how I am using the new annotation: https://www.scrivano.org/posts/2021-01-30-easyseccomp/
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com