Add tests for --terminal and ctrl.c#605
Merged
jnovy merged 1 commit intocontainers:mainfrom Sep 25, 2025
Merged
Conversation
Member
Author
bd0411a to
c31673f
Compare
Member
Author
|
Rebased, @jnovy , this is now ready for review. |
jnovy
requested changes
Sep 24, 2025
Collaborator
jnovy
left a comment
There was a problem hiding this comment.
It seems that the test suite tests only a very limited edge cases. Maybe something like this would make sense too?
@test "ctrl: resize with floating point dimensions" {
test_resize_command_fail "1 10.5 20.3"
}
@test "ctrl: resize with hex numbers" {
test_resize_command_fail "1 0x10 0x20"
}
c31673f to
b049f3a
Compare
This commit adds tests for handling of the tty resize messaages and log reopen messages sent to ctl fifo. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
b049f3a to
42ff673
Compare
Member
Author
|
@jnovy , I've removed the hard-coded |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds tests for handling of the tty resize messaages and
log reopen messages sent to ctl fifo.
Signed-off-by: Jan Kaluza jkaluza@redhat.com