Merged
Conversation
4acc0a4 to
bc573ed
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
This commit does the following: - Moves the common code to create and read from the pipe to new helper funcs `start_oci_sync_pipe_read` and `start_oci_attach_pip_reader`. - Renames the `attach-sync` to `attach-pipe` in tests to stay consistent with the other names. - Adds new tests for _OCI_SYNCPIPE. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
bc573ed to
1b7ec6c
Compare
Member
Author
|
@jnovy , @ashley-cui, this is ready for review. |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit does the following:
start_oci_sync_pipe_readandstart_oci_attach_pip_reader.attach-synctoattach-pipein tests to stay consistent with the other names.