Merged
Conversation
Member
Author
This commit adds three new tests for the --exec-attach option. It also improves start_conmon_with_default_args function so it be executed multiple times in a single test-case for single container. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
f5fa99c to
97f78e5
Compare
Member
Author
|
OK, #602 is merged, so this is ready for review. |
Member
Author
|
@jnovy , @ashley-cui, can you please check this one? |
Collaborator
|
LGTM, assuming it doesn't make sense to implement helpers for pipe operations - the pipe operations are one off? |
Member
Author
|
@jnovy , I will see in the next commit when I add more pipeline operations. I might end up with helpers, but we will see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds three new tests for the --exec-attach option. It also
improves start_conmon_with_default_args function so it be executed
multiple times in a single test-case for single container.