Add more tests for --stdin and --exec.#602
Merged
jnovy merged 1 commit intocontainers:mainfrom Sep 18, 2025
Merged
Conversation
Member
Author
|
This is not a complete test-suite for --exec definitely. I will continue with tests for |
Member
Author
|
@jnovy , can you check this one please? |
Member
Author
|
@ashley-cui, I will also keep you in a loop for these PRs, since we should work together on conmon v3. |
jnovy
requested changes
Sep 17, 2025
Member
Author
|
@jnovy , check now please :-) |
374b4e6 to
e34bd03
Compare
jnovy
requested changes
Sep 18, 2025
| # Additional conmon arguments can be passed to this function. | ||
| start_conmon_with_default_args() { | ||
| local extra_args=("$@") | ||
| timeout 10s "$CONMON_BINARY" \ |
Collaborator
There was a problem hiding this comment.
While at it - would it make sense to standardize these timeouts? Not a blocker - could be done in another PR.
Member
Author
There was a problem hiding this comment.
Let's do that in my next PR. I have different timeouts there already, so I can change it all once in that next PR.
This commit adds few tests for --stdin and --exec and also moves some common functions from 04-runtime.bats to test-helpers.bash. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds few tests for --stdin and --exec and also moves some common functions from 04-runtime.bats to test-helpers.bash.