Remove checks for (long)deprecated libsystemd-journal for libsystemd#456
Merged
haircommander merged 1 commit intocontainers:mainfrom Jan 26, 2024
Merged
Remove checks for (long)deprecated libsystemd-journal for libsystemd#456haircommander merged 1 commit intocontainers:mainfrom
haircommander merged 1 commit intocontainers:mainfrom
Conversation
…systemd https://bugzilla.redhat.com/show_bug.cgi?id=1350301#c2 Signed-off-by: Rahil Bhimjiani <rahil3108@gmail.com>
Contributor
Author
|
ping ... @rhatdan PTAL |
Member
|
LGTM |
Collaborator
|
hm I'm pretty sure this and the associated deprecation will break journald driver support in conmon... I think we need to find the package to replace it |
Member
libsystemd should already have the needed symbols, why wouldn't this be enough? |
Member
|
@rahilarious do we still need this? |
Contributor
Author
you're right. libsystemd has everything. Go may proceed ahead remove libsystemd-journal |
rahilarious
added a commit
to rahilarious/gentoo
that referenced
this pull request
May 3, 2024
drop the patch as it got merged upstream containers/conmon#456 containers/conmon#482 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 9, 2024
drop the patch as it got merged upstream containers/conmon#456 containers/conmon#482 Signed-off-by: Rahil Bhimjiani <me@rahil.rocks> Closes: #36529 Signed-off-by: Florian Schmaus <flow@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1350301#c2