Skip to content

config: mask thermal interrupt info paths#2375

Merged
openshift-merge-bot[bot] merged 1 commit into
containers:mainfrom
giuseppe:mask-thermal-paths
Mar 20, 2025
Merged

config: mask thermal interrupt info paths#2375
openshift-merge-bot[bot] merged 1 commit into
containers:mainfrom
giuseppe:mask-thermal-paths

Conversation

@giuseppe

Copy link
Copy Markdown
Member

On Linux, mask "/proc/interrupts" and
"/sys/devices/system/cpu/*/thermal_throttle" inside containers by default.

It is the equivalent of moby/moby#49560 for Moby.

Mitigates potential Thermal Side-Channel Vulnerability Exploit (https://github.com/moby/moby/security/advisories/GHSA-6fw5-f8r9-fgfm).

@openshift-ci

openshift-ci Bot commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

giuseppe added a commit to giuseppe/buildah that referenced this pull request Mar 20, 2025
Closes: podman-container-tools#6073

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from 7caf5cd to 3236d58 Compare March 20, 2025 10:55
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 20, 2025
vendor the following dependencies:

- containers/common#2375
- podman-container-tools/buildah#6074

Closes: podman-container-tools#25634

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Comment thread pkg/config/default.go
@giuseppe giuseppe force-pushed the mask-thermal-paths branch 4 times, most recently from fbc0a6d to d1bf3f3 Compare March 20, 2025 11:23
giuseppe added a commit to giuseppe/buildah that referenced this pull request Mar 20, 2025
Closes: podman-container-tools#6073

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 20, 2025
vendor the following dependencies:

- containers/common#2375
- podman-container-tools/buildah#6074

Closes: podman-container-tools#25634

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe marked this pull request as ready for review March 20, 2025 13:26
giuseppe added a commit to giuseppe/buildah that referenced this pull request Mar 20, 2025
Closes: podman-container-tools#6073

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 20, 2025
vendor the following dependencies:

- containers/common#2375
- podman-container-tools/buildah#6074

Closes: podman-container-tools#25634

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 20, 2025
vendor the following dependencies:

- containers/common#2375
- podman-container-tools/buildah#6074

Closes: podman-container-tools#25634

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Comment thread pkg/config/default_test.go Outdated
Comment thread pkg/config/default_test.go Outdated
Comment thread pkg/config/default_test.go Outdated
@giuseppe giuseppe force-pushed the mask-thermal-paths branch 2 times, most recently from e6b97c2 to d0e98eb Compare March 20, 2025 16:27
@giuseppe

Copy link
Copy Markdown
Member Author

thanks, fixed now

On Linux, mask "/proc/interrupts" and
"/sys/devices/system/cpu/*/thermal_throttle" inside containers by
default.

It is the equivalent of moby/moby#49560 for Moby.

Mitigates potential Thermal Side-Channel Vulnerability
Exploit (https://github.com/moby/moby/security/advisories/GHSA-6fw5-f8r9-fgfm).

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the mask-thermal-paths branch from d0e98eb to 4c30da0 Compare March 20, 2025 18:22
@rhatdan

rhatdan commented Mar 20, 2025

Copy link
Copy Markdown
Member

LGTM

@mheon

mheon commented Mar 20, 2025

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Mar 20, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit fa53559 into containers:main Mar 20, 2025
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 21, 2025
vendor the following dependencies:

- containers/common#2375
- podman-container-tools/buildah#6074

Closes: podman-container-tools#25634

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 21, 2025
vendor the following dependencies:

- containers/common#2375
- podman-container-tools/buildah#6074

Closes: podman-container-tools#25634

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants