Skip to content

Make the definition of LookupReferenceFunc unconditional#2089

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
nalind:lookup-func-aliases
Jul 15, 2024
Merged

Make the definition of LookupReferenceFunc unconditional#2089
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
nalind:lookup-func-aliases

Conversation

@nalind
Copy link
Copy Markdown
Member

@nalind nalind commented Jul 15, 2024

Move the definition of our LookupReferenceFunc type alias to a file that isn't conditionally compiled, as an alternative to containers/buildah#5628.

@nalind
Make the definition of LookupReferenceFunc unconditional
5b23f7c 
Move the definition of our LookupReferenceFunc type alias to a file that
isn't conditionally compiled.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind nalind mentioned this pull request Jul 15, 2024
Draft
@packit-as-a-service
Copy link
Copy Markdown

packit-as-a-service bot commented Jul 15, 2024

Ephemeral COPR build failed. @containers/packit-build please check.

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jul 15, 2024

LGTM

@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jul 15, 2024

@Luap99 @mheon @lsm5 @edsantiago @flouthoc PTAL

@mheon
Copy link
Copy Markdown
Member

mheon commented Jul 15, 2024

Sure
/lgtm

@aaronlehmann
Copy link
Copy Markdown

aaronlehmann commented Jul 15, 2024

Does this address the bloat issue mentioned in containers/buildah#5532 (comment)?

@openshift-ci openshift-ci bot added the lgtm label Jul 15, 2024
@mheon
Copy link
Copy Markdown
Member

mheon commented Jul 15, 2024

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fdf625d into containers:main Jul 15, 2024
@nalind nalind deleted the lookup-func-aliases branch July 15, 2024 15:16
@nalind nalind mentioned this pull request Jul 15, 2024
Merged
@rhatdan
Copy link
Copy Markdown
Member

rhatdan commented Jul 15, 2024

I believe pulling in common/libimage/manifest versus pulling common/libimage should fix it.

@nalind
Copy link
Copy Markdown
Member Author

nalind commented Jul 15, 2024

Does this address the bloat issue mentioned in containers/buildah#5532 (comment)?

When I look at the go list -deps output for versions of github.com/containers/buildah/define that use libimage.LookupReferenceFunc and manifests.LookupReferenceFunc, the version that uses the definition from manifests has fewer dependencies. Maybe I shouldn't have closed containers/buildah#5628?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mheon mheon

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nalind @rhatdan @mheon @aaronlehmann