Mask thermal paths#6074
Merged
openshift-merge-bot[bot] merged 2 commits intoMar 21, 2025
Merged
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
a26646e to
f4f8efa
Compare
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Mar 20, 2025
vendor the following dependencies: - containers/common#2375 - podman-container-tools/buildah#6074 Closes: podman-container-tools#25634 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
f4f8efa to
2d3e4dd
Compare
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Mar 20, 2025
vendor the following dependencies: - containers/common#2375 - podman-container-tools/buildah#6074 Closes: podman-container-tools#25634 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2d3e4dd to
0e11a5d
Compare
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Mar 20, 2025
vendor the following dependencies: - containers/common#2375 - podman-container-tools/buildah#6074 Closes: podman-container-tools#25634 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Mar 20, 2025
vendor the following dependencies: - containers/common#2375 - podman-container-tools/buildah#6074 Closes: podman-container-tools#25634 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Closes: podman-container-tools#6073 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
0e11a5d to
95fb646
Compare
95fb646 to
cbcdff4
Compare
Contributor
Author
|
@containers/buildah-maintainers ready for review |
That is the same configuration used already by Podman. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
cbcdff4 to
2031709
Compare
lsm5
approved these changes
Mar 21, 2025
lsm5
left a comment
Contributor
There was a problem hiding this comment.
Do we need to add / update tests?
LGTM as such.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
the tests were added to the c/common change |
Contributor
NVM, looks handled in containers/common#2375 . LGTM. |
Contributor
|
/lgtm |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Mar 21, 2025
vendor the following dependencies: - containers/common#2375 - podman-container-tools/buildah#6074 Closes: podman-container-tools#25634 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Mar 21, 2025
vendor the following dependencies: - containers/common#2375 - podman-container-tools/buildah#6074 Closes: podman-container-tools#25634 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
What this PR does / why we need it:
Mask /proc/interrupts and /sys/devices/system/cpu//thermal_throttle by default
Fixes #6073