Replace libimage.LookupReferenceFunc with the manifests version#5628
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Jul 16, 2024
Merged
Conversation
32714bb to
ebad106
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Member
|
LGTM if this works. |
Member
Author
|
Shouldn't be needed with containers/common#2089, closing. |
ebad106 to
49590a8
Compare
Member
Author
|
Reopened and rebased. |
Member
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change fields of the github.com/containers/common/libimage.LookupReferenceFunc type to be of the github.com/containers/common/libimage/manifests.LookupReferenceFunc type. The two types are aliases for each other, but the libimage package refuses to build when podman is using us as a dependency of its remote client. Note that the CachePullSourceLookupReferenceFunc, CachePullDestinationLookupReferenceFunc, CachePushSourceLookupReferenceFunc, and CachePushDestinationLookupReferenceFunc callbacks in define.BuildOptions aren't currently proxied for podman remote clients. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
49590a8 to
b1dff41
Compare
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Change fields of the
github.com/containers/common/libimage.LookupReferenceFunctype to be of thegithub.com/containers/common/libimage/manifests.LookupReferenceFunctype. The two types are aliases for each other, but the libimage package refuses to build when podman is using us as a dependency of its remote client.Note that the
CachePullSourceLookupReferenceFunc,CachePullDestinationLookupReferenceFunc,CachePushSourceLookupReferenceFunc, andCachePushDestinationLookupReferenceFunccallbacks indefine.BuildOptionsaren't currently proxied for podman remote clients.How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Alternate approaches include moving the type aliases from
copier.goingithub.com/containers/common/libimageto a new file that doesn't have build constraints, or having podman actually define its own API types instead of just including ours.Does this PR introduce a user-facing change?