intermediate-images inherit-label test: make it debuggable#4837
intermediate-images inherit-label test: make it debuggable#4837rhatdan merged 1 commit intocontainers:mainfrom
Conversation
Test is currently very hard to debug on failure. Fix that by adding unique test descriptors and a little whitespace. Also, fix a broken/NOP test (copypaste artifact) Signed-off-by: Ed Santiago <santiago@redhat.com>
| run_buildah inspect --format '{{ index .Docker.Config.Labels "somefancylabel"}}' imagetwo | ||
| expect_output "" | ||
|
|
||
| run_buildah inspect --format '{{ index .Docker.Config.Labels "somefancylabel"}}' imagethree |
There was a problem hiding this comment.
SPECIAL NOTE OF THIS CHANGE! github's diff highlighter did not highlight the critical change here: changing imagetwo to imagethree. I am 99.99% certain that this was a copy-paste error. If it is not, please yell loudly now.
kolyshkin
left a comment
There was a problem hiding this comment.
tests/helpers.bash says expect_output is deprecated by assert. Now, I'm sure it does not make sense to convert everything to assert, but maybe use a new version when you touch the code.
|
@kolyshkin point taken, but I was going for ease of review to get this in ASAP (for your #4832, actually, in case it could be helpful in tracking down that weird CI failure). |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Test is currently very hard to debug on failure. Fix that
by adding unique test descriptors and a little whitespace.
Also, fix a broken/NOP test (copypaste artifact)
Signed-off-by: Ed Santiago santiago@redhat.com