[release/2.2] Fix unmarshalling of registered types #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a faithful backport of containerd#53 --- In 7d3d258 I inadvterantly removed support for json unmarshalling for the case when a type implements a protobuf message but is a type that is registered. For types that are registered through the `Register` function typeurl is supposed to ignore the interfaces that the type implements and just use json. This change restores that behavior. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
dmcgowan
approved these changes
Nov 6, 2024
fuweid
approved these changes
Nov 7, 2024
slonopotamus
added a commit
to slonopotamus/buildkit
that referenced
this pull request
Nov 12, 2024
This is a prerequisite to upgrading to containerd 2.x See containerd/typeurl#54 Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
slonopotamus
added a commit
to slonopotamus/buildkit
that referenced
this pull request
Nov 13, 2024
This is a prerequisite to upgrading to containerd 2.x See containerd/typeurl#54 Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
slonopotamus
added a commit
to slonopotamus/buildkit
that referenced
this pull request
Nov 14, 2024
This is a prerequisite to upgrading to containerd 2.x See containerd/typeurl#54 Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a faithful backport of #53
In 7d3d258 I inadvterantly removed
support for json unmarshalling for the case when a type implements a protobuf message but is a type that is registered.
For types that are registered through the
Registerfunction typeurl is supposed to ignore the interfaces that the type implements and just use json.This change restores that behavior.