[Windows] Check for errors when connecting with client#182
Merged
wllenyj merged 1 commit intocontainerd:masterfrom Apr 29, 2023
Merged
[Windows] Check for errors when connecting with client#182wllenyj merged 1 commit intocontainerd:masterfrom
wllenyj merged 1 commit intocontainerd:masterfrom
Conversation
d4a795b to
26c9c2f
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 24.39% 24.39%
=======================================
Files 17 17
Lines 2529 2529
=======================================
Hits 617 617
Misses 1912 1912
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The unwrap() causes a panic. This can happen if the file doesn't exist or there is a small chance when mutliple clients connect quickly that the pipe returns 'All pipe instances are busy.' also causing a panic. This allows the caller to handle these errors and retry if necessary (as is the case with the pipe instances being busy). Signed-off-by: James Sturtevant <jstur@microsoft.com>
26c9c2f to
d96bea3
Compare
quanweiZhou
approved these changes
Apr 20, 2023
Collaborator
quanweiZhou
left a comment
There was a problem hiding this comment.
Thanks @jsturtevant, LGTM.
wllenyj
approved these changes
Apr 23, 2023
This was referenced Apr 25, 2023
Collaborator
Author
|
@wllenyj @Tim-Zhang friendly ping for a merge. I think these last couple PR should have stabilized the windows support. If we can get these merged and a release out then I start using this in containerd/rust-extensions#139. If there is any other work before a release please let me know and I can try to help out. |
KarstenB
pushed a commit
to KarstenB/ttrpc-rust
that referenced
this pull request
May 1, 2025
…nection [Windows] Check for errors when connecting with client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unwrap()on the file when creating the client connection causes a panic. This can happen if the file doesn't exist or there is a small chance when multiple clients connect quickly that the pipe returns 'All pipe instances are busy.' also causing a panic. This allows the caller to handle these errors and retry if necessary (as is the case with the pipe instances being busy).