Skip to content

CI: lock Rust version to 1.66#179

Merged
lifupan merged 1 commit intocontainerd:masterfrom
Tim-Zhang:lock-rust-version
Mar 24, 2023
Merged

CI: lock Rust version to 1.66#179
lifupan merged 1 commit intocontainerd:masterfrom
Tim-Zhang:lock-rust-version

Conversation

@Tim-Zhang
Copy link
Copy Markdown
Member

We've had enough with clippy errors happens with code untouched.
And the clippy(1.68) suggestion about enum Default derive is conflict with lower Rust version(<1.66)

To avoid this problem we lock the rust version and make it steady.

We've had enough with clippy errors happens with code untouched.
And the clippy(1.68) suggestion about enum Default derive is conflict
with lower Rust version(<1.66)

To avoid this problem we lock the rust version and make it
steady.

Signed-off-by: Tim Zhang <tim@hyper.sh>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (476446f) 25.76% compared to head (34003e3) 25.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   25.76%   25.76%           
=======================================
  Files          16       16           
  Lines        2395     2395           
=======================================
  Hits          617      617           
  Misses       1778     1778           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lifupan lifupan merged commit 78de1c5 into containerd:master Mar 24, 2023
@jsturtevant
Copy link
Copy Markdown
Collaborator

could another option be to bump the rust version but use a #[allow(clippy:<rule>)] with a comment that we want to support older versions of the tool chain? How far back do the older rust version need to be supported?

@Tim-Zhang Tim-Zhang deleted the lock-rust-version branch March 24, 2023 18:13
@Tim-Zhang
Copy link
Copy Markdown
Member Author

Tim-Zhang commented Mar 24, 2023

@jsturtevant Not only for the problem we just met but also we want to do this long ago. Because we the developers need a stable expectation that unchanged code should pass the CI as it did last time.

We will increase the version manually when we need afterwards. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants