Make onclose an option.#35
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Apr 11, 2019
Merged
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
Member
|
LGTM |
thaJeztah
added a commit
to thaJeztah/containerd
that referenced
this pull request
Apr 27, 2019
full diff: containerd/ttrpc@f02858b...699c4e4 - containerd/ttrpc#33 Fix returns error message - containerd/ttrpc#35 Make onclose an option Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/containerd
that referenced
this pull request
Apr 29, 2019
full diff: containerd/ttrpc@f02858b...699c4e4 - containerd/ttrpc#33 Fix returns error message - containerd/ttrpc#35 Make onclose an option Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 8c5779c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
OnClosean create option instead of a separate function.NewClientstarts a goroutine, which callscloseFuncbefore exit.Setting
closeFuncafterNewClientseparately introduces a race condition:closeFuncis called given that the connection may be gone beforeOnCloseis set.Signed-off-by: Lantao Liu lantaol@google.com