Fix Method of judging command execution failure#52
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jun 3, 2019
Merged
Fix Method of judging command execution failure#52crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
should judge restore and run command execution failure depend both on error and status Monitor.Wait() return Signed-off-by: Ace-Tang <aceapril@126.com>
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=========================================
- Coverage 6.18% 6.12% -0.06%
=========================================
Files 7 7
Lines 631 637 +6
=========================================
Hits 39 39
- Misses 585 591 +6
Partials 7 7
Continue to review full report at Codecov.
|
Contributor
Author
|
@crosbymichael , would you help to check this |
Member
|
LGTM |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Aug 26, 2019
- github.com/containerd/go-runc containerd/go-runc@7d11b49...9007c24 - containerd/go-runc#52 Fix Method of judging command execution failure - fixes "init.pid: no such file or directory: unknown" errors Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
dmcgowan
pushed a commit
to thaJeztah/docker
that referenced
this pull request
Oct 4, 2019
- github.com/containerd/go-runc containerd/go-runc@7d11b49...e029b79 - containerd/go-runc#52 Fix Method of judging command execution failure - fixes "init.pid: no such file or directory: unknown" errors - containerd/go-runc#54 avoid setting NOTIFY_SOCKET from calling process Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Derek McGowan <derek@mcgstyle.net>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Oct 8, 2019
- github.com/containerd/go-runc containerd/go-runc@7d11b49...e029b79 - containerd/go-runc#52 Fix Method of judging command execution failure - fixes "init.pid: no such file or directory: unknown" errors - containerd/go-runc#54 avoid setting NOTIFY_SOCKET from calling process Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Derek McGowan <derek@mcgstyle.net> Upstream-commit: 1617be92d301de1386adabad5f241d3653b6c8ff Component: engine
burnMyDread
pushed a commit
to burnMyDread/moby
that referenced
this pull request
Oct 21, 2019
- github.com/containerd/go-runc containerd/go-runc@7d11b49...e029b79 - containerd/go-runc#52 Fix Method of judging command execution failure - fixes "init.pid: no such file or directory: unknown" errors - containerd/go-runc#54 avoid setting NOTIFY_SOCKET from calling process Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Derek McGowan <derek@mcgstyle.net> Signed-off-by: zach <Zachary.Joyner@linux.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
========================================
Coverage ? 6.12%
========================================
Files ? 7
Lines ? 637
Branches ? 0
========================================
Hits ? 39
Misses ? 591
Partials ? 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should judge restore and run command execution failure depend both on error and
status Monitor.Wait() return.
Since Monitor.Wait() always return nil as long as command execute.
Signed-off-by: Ace-Tang aceapril@126.com
I only test it with pouch, before the patch
and with this patch in containerd, it can get correct error log