Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Conversation

@ijc
Copy link
Contributor

@ijc ijc commented Sep 15, 2017

This carries #241 with additional fixes to the test suite from me. From @Random-Liu's original:

For image volume, currently we only:

  1. Create host directory and mount into the image;
  2. Change the ownership of the host directory to be the same with mount point inside the image.

What we are going to do in the future:

  1. Consider whether we need to copy existing content in the image into the volume. Support ExposedPorts and Volumes in image config. #186.
  2. Consider whether we should add the helper into containerd Add WithVolume helper in client. containerd#1482.
  3. Consider how to properly manage these volumes in kubelet Ensure that host disk space used by Docker volume is accounted for kubernetes/kubernetes#52032.

Signed-off-by: Lantao Liu lantaol@google.com
Signed-off-by: Ian Campbell ijc@docker.com

This is achieved by switching `assert.NoError` to `require.NoError` in several
places.

Otherwise the test code will continue and dereference a nil spec, leading to a
panic which obscures the real failure.

Signed-off-by: Ian Campbell <ijc@docker.com>
Ian Campbell and others added 2 commits September 15, 2017 11:25
Signed-off-by: Ian Campbell <ijc@docker.com>
Signed-off-by: Lantao Liu <lantaol@google.com>
@Random-Liu Random-Liu self-assigned this Sep 15, 2017
@Random-Liu Random-Liu added this to the v1.0.0-alpha.0 milestone Sep 15, 2017
@Random-Liu Random-Liu merged commit da31647 into containerd:master Sep 15, 2017
@Random-Liu
Copy link
Member

@ijc Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants