This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Explicitly specify trusty in travis.#1312
Merged
Random-Liu merged 4 commits intocontainerd:masterfrom Oct 9, 2019
Merged
Conversation
bba011d to
bae7466
Compare
d92130a to
a2814a4
Compare
Signed-off-by: Lantao Liu <lantaol@google.com>
Signed-off-by: Lantao Liu <lantaol@google.com>
Signed-off-by: Lantao Liu <lantaol@google.com>
Signed-off-by: Lantao Liu <lantaol@google.com>
a2814a4 to
2a9a982
Compare
mikebrow
approved these changes
Oct 9, 2019
Member
mikebrow
left a comment
There was a problem hiding this comment.
LGTM
See nit for tracking issue
| @echo "$(WHALE) $@" | ||
| $(GO) get -u github.com/golangci/golangci-lint/cmd/golangci-lint | ||
| $(GO) get -d github.com/golangci/golangci-lint/cmd/golangci-lint | ||
| @cd $(GOPATH)/src/github.com/golangci/golangci-lint/cmd/golangci-lint; \ |
Member
There was a problem hiding this comment.
suggestion... let's open an issue (or add a line to an existing one) to use containerd/script/setup/install-dev-tools, maybe also move said script to containerd/project
Member
Author
There was a problem hiding this comment.
This was referenced Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1311.
This PR:
.exestopped working somehow..travis.ymlbased on new default ubuntu distroxenial. https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment2 and 3 should be cherry-picked.
Signed-off-by: Lantao Liu lantaol@google.com