Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

[release/1.3] fix: support empty auth config for anonymous registry#1253

Merged
Random-Liu merged 1 commit intocontainerd:release/1.3from
awesomenix:release/1.3
Aug 30, 2019
Merged

[release/1.3] fix: support empty auth config for anonymous registry#1253
Random-Liu merged 1 commit intocontainerd:release/1.3from
awesomenix:release/1.3

Conversation

@awesomenix
Copy link
Contributor

@awesomenix awesomenix commented Aug 29, 2019 •
edited
Loading

cherry-pick f41675d from master
PR: #1250

@k8s-ci-robot
Copy link

k8s-ci-robot commented Aug 29, 2019

Hi @awesomenix. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awesomenix awesomenix mentioned this pull request Aug 29, 2019
Merged
@awesomenix
Copy link
Contributor Author

awesomenix commented Aug 29, 2019

Cherry pick commit 567cd57

mikebrow
mikebrow approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Random-Liu
Copy link
Member

Random-Liu commented Aug 30, 2019

@awesomenix I think we usually cherry-pick the original commit instead of the merge commit.

@Random-Liu Random-Liu self-assigned this Aug 30, 2019
@Random-Liu Random-Liu added this to the v1.3 milestone Aug 30, 2019
@awesomenix
fix: support empty auth config for anonymous registry
4eff3e2 
- empty username means caller wants to use no credentials, typically for anonymous registry
- Fixes #1249

Signed-off-by: Nishchay Kumar <mrawesomenix@gmail.com>
@awesomenix
Copy link
Contributor Author

awesomenix commented Aug 30, 2019

Oops! sorry about that. Doing that now

@awesomenix awesomenix changed the title Merge pull request #1250 from awesomenix/fixemptyauth fix: support empty auth config for anonymous registry Aug 30, 2019
@awesomenix awesomenix closed this Aug 30, 2019
@awesomenix awesomenix reopened this Aug 30, 2019
@mikebrow
Copy link
Member

mikebrow commented Aug 30, 2019

/ok-to-test

@Random-Liu Random-Liu changed the title fix: support empty auth config for anonymous registry [release/1.3] fix: support empty auth config for anonymous registry Aug 30, 2019
@Random-Liu Random-Liu merged commit 0165d51 into containerd:release/1.3 Aug 30, 2019
@Random-Liu
Copy link
Member

Random-Liu commented Aug 30, 2019

/lgtm

@dmcgowan dmcgowan mentioned this pull request Sep 4, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Random-Liu Random-Liu

Labels

lgtm ok-to-test size/XS

Projects

None yet

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@awesomenix @k8s-ci-robot @Random-Liu @mikebrow