Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

fix: support empty auth config for anonymous registry#1250

Merged
Random-Liu merged 1 commit intocontainerd:masterfrom
awesomenix:fixemptyauth
Aug 29, 2019
Merged

fix: support empty auth config for anonymous registry#1250
Random-Liu merged 1 commit intocontainerd:masterfrom
awesomenix:fixemptyauth

Conversation

@awesomenix
Copy link
Contributor

@awesomenix awesomenix commented Aug 28, 2019

@k8s-ci-robot
Copy link

k8s-ci-robot commented Aug 28, 2019

Hi @awesomenix. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awesomenix
Copy link
Contributor Author

awesomenix commented Aug 28, 2019

/assign @Random-Liu

@mikebrow
Copy link
Member

mikebrow commented Aug 28, 2019

/ok-to-test

mikebrow
mikebrow reviewed Aug 28, 2019
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@awesomenix
fix: support empty auth config for anonymous registry
f41675d 
- empty username means caller wants to use no credentials, typically for anonymous registry
- Fixes #1249

Signed-off-by: Nishchay Kumar <mrawesomenix@gmail.com>
mikebrow
mikebrow approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@andyzhangx andyzhangx mentioned this pull request Aug 29, 2019
Closed
@Random-Liu Random-Liu added this to the v1.3 milestone Aug 29, 2019
@Random-Liu
Copy link
Member

Random-Liu commented Aug 29, 2019

/lgtm

@awesomenix I think we want this for containerd 1.3, can you send out a cherry-pick to release/1.3? Thanks!

@Random-Liu Random-Liu merged commit 567cd57 into containerd:master Aug 29, 2019
@awesomenix
Copy link
Contributor Author

awesomenix commented Aug 29, 2019

@Random-Liu, will cherry pick to 1.3, will need it for 1.2 as well, will send out cherry pick for 1.2 as well.

@awesomenix
Copy link
Contributor Author

awesomenix commented Aug 29, 2019

Cherry-picked for 1.3 #1253
Cherry-picked for 1.2 #1254

This was referenced Aug 30, 2019
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Random-Liu Random-Liu

@mikebrow mikebrow

Labels

lgtm ok-to-test size/XS

Projects

None yet

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

Empty username and password return "no auth config"

4 participants

@awesomenix @k8s-ci-robot @mikebrow @Random-Liu