This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Make sure exec process is killed when context is canceled.#1156
Merged
mikebrow merged 1 commit intocontainerd:masterfrom May 29, 2019
Merged
Make sure exec process is killed when context is canceled.#1156mikebrow merged 1 commit intocontainerd:masterfrom
mikebrow merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When context is cancelled, the
process.Killwon't work. We need to kill the process in the cleanup defer.Signed-off-by: Lantao Liu lantaol@google.com