Remove walker diff plugin for Windows #9680
Conversation
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
|
@kiashok fyi |
|
We can take this in, I still have a few questions about the impact. Does the native snapshotter still work on Windows for testing and will this differ still work with that snapshotter? Does this fail on specific mount types which we could just filter out in the walking differ? The differs should be able to return NotImplemented when it is given parameters it cannot use. We also need to be smarter in the transfer service about the default unpack configurations, it was recently updated to not set a static default but only apply a default when nothing is configured. |
|
cc @ambarve |
The |
The walker plugin isn't used on Windows so it shouldn't be loaded. It results in:
Fixes #8563
After #9432 the local transfer service fails to pull Windows containers because it incorrectly selects the wrong differ. See #8563 for details on the failures with the transfer service.
The issue arises because the
platform.Parse/Formatdoesn't pass the all the required info and would be fixed by #9609 allowing it to select the correct differ. In this case we still can't use the walker so we should remove it from Windows default configuration.