Skip to content

ctr: use transfer service by default #9432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fuweid merged 1 commit into from
Jan 19, 2024
Merged

ctr: use transfer service by default #9432

fuweid merged 1 commit into from
Jan 19, 2024

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 28, 2023

Prior to this commit, --local=false had to be explicitly specified to opt-in to the transfer service

@AkihiroSuda AkihiroSuda requested a review from dmcgowan November 28, 2023 14:09
@AkihiroSuda AkihiroSuda added this to the 2.0 milestone Nov 28, 2023
@dmcgowan
Copy link
Member

dmcgowan commented Nov 28, 2023 •
edited
Loading

Thanks! I'll look into the failure here

=== RUN   TestImageLoad
    image_load_test.go:38: docker save image into tarball
    image_load_test.go:48: make sure no such image in cri
    image_load_test.go:55: load image in cri
    image_load_test.go:62: make sure image is loaded
    image_load_test.go:65: 
        	Error Trace:	/home/runner/work/containerd/containerd/integration/image_load_test.go:65
        	Error:      	Received unexpected error:
        	            	timeout exceeded
        	Test:       	TestImageLoad
--- FAIL: TestImageLoad (10.89s)

and

=== RUN   TestImageLoad
    image_load_test.go:38: docker save image into tarball
    image_load_test.go:48: make sure no such image in cri
    image_load_test.go:55: load image in cri
    image_load_test.go:60: 
        	Error Trace:	D:/a/containerd/containerd/src/github.com/containerd/containerd/integration/image_load_test.go:60
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	TestImageLoad
        	Messages:   	output: "ctr: rpc error: code = Unknown desc = image might be filtered out\n"
--- FAIL: TestImageLoad (39.23s)
=== RUN   TestCRIImagePullTimeout

@samuelkarp
Copy link
Member

samuelkarp commented Nov 29, 2023

/retest

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jan 4, 2024

Thanks! I'll look into the failure here

Did you find the cause of the failure?

@AkihiroSuda AkihiroSuda force-pushed the ctr-transfer-service-default branch from c045882 to 0a3fa95 Compare January 11, 2024 14:57
@AkihiroSuda
ctr: use transfer service by default
eb123db 
Prior to this commit, `--local=false` had to be explicitly specified to
opt-in to the transfer service

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda force-pushed the ctr-transfer-service-default branch from 0a3fa95 to eb123db Compare January 18, 2024 14:42
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jan 18, 2024

/retest

@AkihiroSuda AkihiroSuda requested review from fuweid and ktock January 18, 2024 23:51
fuweid
fuweid approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid added this pull request to the merge queue Jan 19, 2024
Merged via the queue into containerd:main with commit 44cd362 Jan 19, 2024
This was referenced Jan 24, 2024
Closed
Merged
@jsturtevant jsturtevant mentioned this pull request Feb 5, 2024
Merged
@KCSesh KCSesh mentioned this pull request Nov 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@fuweid fuweid fuweid approved these changes

@ktock ktock ktock approved these changes

Assignees

No one assigned

Labels

size/S

Projects

Pull Request Review
Archived in project

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@AkihiroSuda @dmcgowan @samuelkarp @fuweid @ktock @k8s-ci-robot