Skip to content

[release/1.6] Bump grpc to v1.56.3#9285

Closed
thaJeztah wants to merge 2 commits intocontainerd:release/1.6from
thaJeztah:1.6_backport_update_grpc
Closed

[release/1.6] Bump grpc to v1.56.3#9285
thaJeztah wants to merge 2 commits intocontainerd:release/1.6from
thaJeztah:1.6_backport_update_grpc

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Oct 23, 2023

@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Comment on lines -137 to -141
github.com/gogo/googleapis => github.com/gogo/googleapis v1.3.2

// urfave/cli must be <= v1.22.1 due to a regression: https://github.com/urfave/cli/issues/1092
github.com/urfave/cli => github.com/urfave/cli v1.22.1
google.golang.org/genproto => google.golang.org/genproto v0.0.0-20200224152610-e50cd9704f63
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github.com/gogo/googleapis and google.golang.org/genproto replace rules had to be removed, as module resolution failed with them (golang.org/x/oauth2 and other failures)

@thaJeztah thaJeztah force-pushed the 1.6_backport_update_grpc branch from 8bd84cd to 136c0bc Compare October 23, 2023 09:26
github.com/google/uuid v1.3.0 // indirect
github.com/imdario/mergo v0.3.12 // indirect
github.com/klauspost/compress v1.11.13 // indirect
github.com/klauspost/compress v1.15.9 // indirect
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting one; I was actually looking why it updated, but I'm guessing that integration/client uses some dependencies that are not used in the main module; and because of that it forces it to be updated;

github.com/klauspost/compress  has different values in the go.mod files require section:  v1.11.13 in root go.mod  v1.15.9 in integration/client/go.mod

Updating seems like a sane thing to do, so let me add a commit to update the version

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added #7325

Kazuyoshi Kato and others added 2 commits October 23, 2023 11:54
The package has multiple improvements and bug fixes.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
(cherry picked from commit d063597)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 1.6_backport_update_grpc branch from 136c0bc to ac90bad Compare October 23, 2023 09:55
@thaJeztah
Copy link
Copy Markdown
Member Author

Looks like we need to update the project checks (to get rid ot the vndr install);

 github.com/kunalkushwaha/ltag
  go: downloading github.com/LK4D4/vndr v0.1.2
  go: github.com/LK4D4/vndr@latest: github.com/LK4D4/vndr@v0.1.2: verifying module: github.com/LK4D4/vndr@v0.1.2: Get "https://sum.golang.org/lookup/github.com/!l!k4!d4/vndr@v0.1.2": EOF
  Error: Process completed with exit code 1.

@k8s-ci-robot
Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the Stale label Feb 27, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2024

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants