Skip to content

Bump grpc to v1.51.0#7709

Merged
mxpv merged 1 commit intocontainerd:mainfrom
lucacome:bump-grpc
Dec 14, 2022
Merged

Bump grpc to v1.51.0#7709
mxpv merged 1 commit intocontainerd:mainfrom
lucacome:bump-grpc

Conversation

@lucacome
Copy link
Copy Markdown
Contributor

@lucacome lucacome commented Nov 22, 2022

  • Bumps grpc to v1.51.0
  • Bumps genproto to v0.0.0-20221206210731-b1a01be3a5f6

@k8s-ci-robot
Copy link
Copy Markdown

Hi @lucacome. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucacome lucacome force-pushed the bump-grpc branch 3 times, most recently from 386e91b to 8795fc8 Compare November 24, 2022 02:29
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucacome lucacome force-pushed the bump-grpc branch 2 times, most recently from 65cdb8c to 0140b80 Compare December 6, 2022 23:54
@lucacome
Copy link
Copy Markdown
Contributor Author

lucacome commented Dec 6, 2022

Removed unrelated changes.
For some reason it wanted me to update two unrelated deps, so I did it

go.opencensus.io  has different values in the go.mod files require section:  v0.23.0 in root go.mod  v0.24.0 in integration/client/go.mod
github.com/stretchr/testify  has different values in the go.mod files require section:  v1.8.0 in root go.mod  v1.8.1 in integration/client/go.mod

Signed-off-by: Luca Comellini <luca.com@gmail.com>
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow
Copy link
Copy Markdown
Member

/ok-to-test

@mikebrow
Copy link
Copy Markdown
Member

I see kubernetes moved up to 1.51 grpc in main post k/k v1.26 which just went out. Is this change tied to an issue?

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green.. have a question re any open issue requiring the update :-)

@lucacome
Copy link
Copy Markdown
Contributor Author

@mikebrow not tied to an issue, just keeping it up to date. Not sure why they waited in k8s to merge it.

Seems like this test keeps failing....

@mxpv mxpv merged commit 373c26d into containerd:main Dec 14, 2022
@lucacome lucacome deleted the bump-grpc branch December 14, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants