Add missing unpacker.Wait for image import#9028
Merged
kzys merged 1 commit intocontainerd:mainfrom Aug 31, 2023
Merged
Conversation
- For remote snapshotters, the unpack phase serves as an important step for preparing the remote snapshot. With the missing unpacker.Wait, the snapshotter `Prepare` context is always canceled. - This patch allows remote snapshotter based archives to be imported via the transfer service or `ctr image import` Signed-off-by: Edgar Lee <edgarhinshunlee@gmail.com>
|
Hi @hinshun. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dmcgowan
approved these changes
Aug 31, 2023
|
Related but not blocking this PR: #9039 |
kzys
approved these changes
Aug 31, 2023
This was referenced Feb 14, 2024
hinshun
pushed a commit
to hinshun/containerd
that referenced
this pull request
Feb 18, 2024
Add missing unpacker.Wait for image import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unpacker.Wait, the snapshotterPreparecontext is always canceled.ctr image import