Skip to content

Remove temporary replace for fuzzer library#8990

Merged
mxpv merged 1 commit intocontainerd:mainfrom
jsturtevant:bump-go-fuzz
Aug 21, 2023
Merged

Remove temporary replace for fuzzer library#8990
mxpv merged 1 commit intocontainerd:mainfrom
jsturtevant:bump-go-fuzz

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

@jsturtevant jsturtevant commented Aug 19, 2023

I found that after AdaLogics/go-fuzz-headers#113 merged our CI started failing in containerd/rust-extensions#147 (comment)

This removes the temporary workaround (since the PR that had the fix merged upstream)

/cc @AdamKorcz

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 19, 2023

@jsturtevant: GitHub didn't allow me to request PR reviews from the following users: AdamKorcz.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

I found that after AdaLogics/go-fuzz-headers#113 merged our CI started failing in containerd/rust-extensions#147 (comment)

This removes the temporary workaround (since the PR that had the fix merged upstream)

/cc @AdamKorcz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 19, 2023

Hi @jsturtevant. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsturtevant jsturtevant mentioned this pull request Aug 19, 2023
Merged
@jsturtevant
Remove temporary replace
8399a4e 
Signed-off-by: James Sturtevant <jstur@microsoft.com>
@jsturtevant jsturtevant changed the title Remove temporary replace Remove temporary replace for fuzzer library Aug 21, 2023
@jsturtevant
Copy link
Copy Markdown
Contributor Author

jsturtevant commented Aug 21, 2023

/assign @mxpv

@AdamKorcz
Copy link
Copy Markdown
Contributor

AdamKorcz commented Aug 21, 2023

Thanks @jsturtevant using 20230811130428-ced1acdcaa24 should fix it. As a side note, I think AdaLogics/go-fuzz-headers#112 was the cause of this, not AdaLogics/go-fuzz-headers#113.

@mxpv mxpv merged commit 579b257 into containerd:main Aug 21, 2023
@jsturtevant jsturtevant mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

Assignees

@mxpv mxpv

Labels

needs-ok-to-test

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jsturtevant @k8s-ci-robot @AdamKorcz @samuelkarp @mxpv @estesp